[Gecko Bug 1703592] Deal with non-finite viewbox / viewports. #28427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the test-case we end up dividing viewbox/viewport, which is inf/inf, end up with NaN, and boom. Differential Revision: https://phabricator.services.mozilla.com/D111325 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1703592 gecko-commit: 2f2b7c9e14deccb122a8124b9072686506cdcee9 gecko-reviewers: longsonr
wpt-pr-bot
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test-case we end up dividing viewbox/viewport, which is inf/inf,
end up with NaN, and boom.
Differential Revision: https://phabricator.services.mozilla.com/D111325
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1703592
gecko-commit: 2f2b7c9e14deccb122a8124b9072686506cdcee9
gecko-reviewers: longsonr