Change slot.assign() from sequence to variadic #28699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 26, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2851439
branch
3 times, most recently
from
2b8ba54
to
a186673
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2851439
branch
2 times, most recently
from
8add20d
to
053a177
Compare
This spec change wasn't noticed when [1] was landed. This CL aligns the implementation and WPTs with the spec IDL file [2]. As with [1], the use counter [3] is *very* low, so there should not be compat concerns with this change. I have requested a re-review of the I2S, at [4]. I will wait to ship this until I receive 3 more LGTMs there. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2824763 [2] https://html.spec.whatwg.org/#htmlslotelement [3] https://chromestatus.com/metrics/feature/timeline/popularity/3442 [4] https://groups.google.com/a/chromium.org/g/blink-dev/c/6U78F3KWJ78/m/CExRJ9KlBQAJ Fixed: 1202591 Bug: 1196842 Change-Id: If0e21d2f3329b9903a9ffeb0df4a80143f6e1581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2851439 Commit-Queue: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#879190}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2851439
branch
from
053a177
to
e38e1b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec change wasn't noticed when [1] was landed. This CL aligns
the implementation and WPTs with the spec IDL file [2]. As with [1],
the use counter [3] is very low, so there should not be compat
concerns with this change.
I have requested a re-review of the I2S, at [4]. I will wait to ship
this until I receive 3 more LGTMs there.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/2824763
[2] https://html.spec.whatwg.org/#htmlslotelement
[3] https://chromestatus.com/metrics/feature/timeline/popularity/3442
[4] https://groups.google.com/a/chromium.org/g/blink-dev/c/6U78F3KWJ78/m/CExRJ9KlBQAJ
Fixed: 1202591
Bug: 1196842
Change-Id: If0e21d2f3329b9903a9ffeb0df4a80143f6e1581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2851439
Commit-Queue: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879190}