fix: stop async scripts running between parser pumps #28485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 14, 2021
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2826128
branch
3 times, most recently
from
b466f33
to
d27431f
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2826128
branch
3 times, most recently
from
54d35ed
to
70364b7
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2826128
branch
from
70364b7
to
6191bb9
Compare
Some pages assume that async scripts don't run in between sync <script> tags. They probably shouldn't, but this fixes the behaviour. Bug: 1197376, 901056 Change-Id: Icd1779f164db77794e25dbcd6e3e92582a55d7a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826128 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/master@{#878839}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2826128
branch
from
6191bb9
to
a09f40d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some pages assume that async scripts don't run in between sync
<script> tags. They probably shouldn't, but this fixes the
behaviour.
Bug: 1197376, 901056
Change-Id: Icd1779f164db77794e25dbcd6e3e92582a55d7a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2826128
Commit-Queue: Richard Townsend <richard.townsend@arm.com>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#878839}