-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: build vehicle name filter #8984
Conversation
A hotkey can be added to make the edit box get the focus, like in #8908. Of course it could be in a separate commit or PR. :) |
Seems to me that the hotkey can be rolled into this PR, probably as a separate commit |
There you go! |
ping ping! |
Hi devs, could you make a deployment so people can test this feature? |
NewGRF often put some extra properties/text into the panel below the list.
|
Hmm, a text filter for cargo-refittability is probably a bad idea after all. It won't work with build+refit, so would readd the old confusion about that. |
Yeah I kinda agree with that. What do you think of the filter in a third row vs with the rest above? |
I agree that filtering refittable cargos is not a good use of this filter. There's already a drop-down for that. My concern with the current implementation of the filter textbox to the right of the cargo types dropdown is that it makes said dropdown very narrow. Long cargo names (such as in |
Motivation / Problem
As discussed in #8723, users will benefit from having the option to filter the Build Vehicle list by typing a string. This would be especially useful when playing with NewGRF that include tons of vehicles.
Description
This change adds a textbox to the Build Vehicle window so users can enter a keyword to find vehicles that match that keyboard. This works for all the types of vehicles and it's compatible with the existing filters.
This is what it looks like:
The text boxes do not immediately get focus to not break user's hotkeys.
Limitations
Nope.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.