Add WPT for blocked navigation to about:srcdoc #28540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 16, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2831536
branch
from
aeec47e
to
cd7af1a
Compare
Navigations to "about:srcdoc" should fail per the HTML specification. Indeed, as per [1] the "about:srcdoc" URL is "unresovable". This URL is never handled (i.e. treated with an appropriate locally-created response) anywhere in the navigation algorithm [2]. In fact the only time it ever seems to be handled is in the process the iframe attributes algorithm [3], which is not invoked when navigating via `window.open()` or via setting `window.location`. This CL adds tests for this. [1] https://html.spec.whatwg.org/multipage/urls-and-fetching.html#about%3Asrcdoc [2] https://html.spec.whatwg.org/#navigating-across-documents [3] https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes Bug: 1169736 Change-Id: I6e92b6c930a15fc77aff3ee700a6b01b107e1d41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831536 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#879713}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2831536
branch
from
cd7af1a
to
506eb67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigations to "about:srcdoc" should fail per the HTML specification.
Indeed, as per [1] the "about:srcdoc" URL is "unresovable". This URL
is never handled (i.e. treated with an appropriate locally-created
response) anywhere in the navigation algorithm [2]. In fact the only
time it ever seems to be handled is in the process the iframe
attributes algorithm [3], which is not invoked when navigating via
window.open()or via settingwindow.location.This CL adds tests for this.
[1] https://html.spec.whatwg.org/multipage/urls-and-fetching.html#about%3Asrcdoc
[2] https://html.spec.whatwg.org/#navigating-across-documents
[3] https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes
Bug: 1169736
Change-Id: I6e92b6c930a15fc77aff3ee700a6b01b107e1d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2831536
Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#879713}