[Gecko Bug 1703921] Ensure h2 server terminates threads when connections are closed #28433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the location where we send the "close thread" message so it will always happen when we're waiting on the thread to join. Also stop blocking forever on queues, but spin the loop every second to check if the connection closed flag got set. Differential Revision: https://phabricator.services.mozilla.com/D111323 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1703921 gecko-commit: f22a4ed1ed22fe69008fc1036c81baec9e1c4527 gecko-reviewers: twisniewski
wpt-pr-bot
approved these changes
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the location where we send the "close thread" message so it will
always happen when we're waiting on the thread to join. Also stop
blocking forever on queues, but spin the loop every second to check if
the connection closed flag got set.
Differential Revision: https://phabricator.services.mozilla.com/D111323
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1703921
gecko-commit: f22a4ed1ed22fe69008fc1036c81baec9e1c4527
gecko-reviewers: twisniewski