Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error checking when uploading translations #41

Merged
merged 2 commits into from May 4, 2021
Merged

Improve error checking when uploading translations #41

merged 2 commits into from May 4, 2021

Conversation

frosch123
Copy link
Member

Fixes

  • When uploading files that exceeded the upload size limit, eints would truncate them, and try to process the rest anyway. (very weird)
  • Truncation could result in invalid utf-8 sequences, resulting in status 500.
  • The upload script considered uploads successful, when eints redirected to a user-friendly pages listing the problems.

@frosch123
Fix: when uploaded files exceed the upload size limit, reject them en…
c80c28c 
…tirely instead of processing some truncated file.
@frosch123
Fix: uploading broken language files does not necessarily result in a…
6a5d703 
… 4xx status. In most cases eints redirects to a summary page with status 2xx.
@LordAro LordAro merged commit 125570b into OpenTTD:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frosch123 @TrueBrain @LordAro