Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8981: Don't attempt to re-reserve path if already entering/entered depot. #9000

Merged
merged 1 commit into from Apr 10, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 10, 2021

Motivation / Problem

When placing a signal on top of a train, an attempt is made to unreserve and re-reserve the path of the train. This is not possible if the head of the train is already inside a depot, as there is no further path to reserve. This flags the train as stuck, requiring manual intervention.

Description

This patch solves this by not attempting to re-reserve the train's path if it is already entering, or has entered a depot.

Limitations

Path signals. Here lie dragons.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN PeterN changed the title Fix [#8981]: Don't attempt to re-reserve path if already entering/entered depot. Fix #8981: Don't attempt to re-reserve path if already entering/entered depot. Apr 10, 2021
@nielsmh nielsmh merged commit f9460c0 into OpenTTD:master Apr 10, 2021
@PeterN PeterN deleted the issue-8981 branch April 10, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants