Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimap too small on Retina displays #8998

Open
Crazor opened this issue Apr 10, 2021 · 11 comments
Open

Minimap too small on Retina displays #8998

Crazor opened this issue Apr 10, 2021 · 11 comments
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests!

Comments

@Crazor
Copy link

Crazor commented Apr 10, 2021

Version of OpenTTD

1.11.0

Expected result

I expect to be able to zoom into the minimap at least one, better two more steps.

Actual result

The minimap is too small on retina screens even when fully zoomed in

Steps to reproduce

Run OpenTTD on a Mac with Retina display, open the minimap, zoom in all the way.

System and Settings

  • MacBook Air 2020 13" (2560x1600px)
  • System display settings: Select "scaled" and then the rightmost icon for maximum area
  • UI element size: quad
  • Font size: double
  • openttd.cfg:
small_font = /Users/dhe/Library/Fonts/DejaVuSans.ttf
medium_font = /Users/dhe/Library/Fonts/DejaVuSans-Bold.ttf
large_font = /Users/dhe/Library/Fonts/DejaVuSerif-Bold.ttf
mono_font = /Users/dhe/Library/Fonts/DejaVuSansMono-Bold.ttf
small_size = 14
medium_size = 15
large_size = 20
mono_size = 14

The above settings give me a nice and playable OpenTTD experience. Viewport zoom levels and UI size are perfect:
Bildschirmfoto 2021-04-10 um 16 12 53

The minimap is not, however. This is a 128x256 map:
Bildschirmfoto 2021-04-10 um 16 13 03

I think this configuration could use at least one, if not two more levels to zoom in. I briefly looked into the source code and noticed that as zoom levels are "increase to zoom out", there is no easy way for me to set a zoom level below 1. Fractional zoom levels seem to need a bunch of work. Maybe the minimap scaling should be always blown up to 2x or 4x size depending on the UI element size setting? The following is a 4096x4096 map zoomed out all the way, so maybe there should be one or two additional zoom-out levels added as well then:
Bildschirmfoto 2021-04-10 um 16 17 56

@JGRennison
Copy link
Contributor

@ldpl was looking into this recently citymania-org/cmclient@6f8e0c1

I've not actually tried the above myself.

@Crazor
Copy link
Author

Crazor commented Apr 10, 2021

Yup, can confirm that CM's Minimap is looking great on my machine (128x256 map):
Bildschirmfoto 2021-04-10 um 16 49 24

@Wolfolo
Copy link

Wolfolo commented Apr 11, 2021

I don't have a retina display (or a Mac) but I would like a bigger smallmap too, I usually play 64x64 and I have the same problem shown on the second image, so here is my +1

And maybe I could even PR it by myself if I'll find some will power to do it.

@Crazor
Copy link
Author

Crazor commented Apr 12, 2021

Interesting, I thought that this was an artifact of the doubled up resolution. I used to play a lot a couple of years ago, and from what I remember also very small maps, however I could not remember seeing the tiny minimap before.

So just pixel-doubling for highdpi systems does not seem to be the solution to this issue. Just to be sure (since "retina display" is an Apple marketing term): @Wolfolo, what's your resolution and panel size? It's not one of those 4k displays, is it?

@Wolfolo
Copy link

Wolfolo commented Apr 12, 2021

The good old 1920x1080 iirc set as windowed matching desktop resolution, so nothing so weird.
I'll retry with different settings

@Sgt-Nukem
Copy link

I installed the April Fools Day release on Steam just for some quick childhood memories but got quickly addicted again to it. Nice work guys! 💪

But this is one of the main issues I have with it as well.

Here's OpenTTD on a Samsung CRG9 32:9 monitor with its 5120x1440 resolution at double-font-size and double-ui-element-size (which make it a perfect fit otherwise):
1536610_20210414191756_1
As you can see by the disabled 'plus' icon the minimap is at maximum zoom level currently!

It's not just the zoom level that is missing AT LEAST 3 more steps, the minimap window has other issues as well:

  • The font size for the map legend is FAAAAAR too small - it doesn't seem to care about 'double-font-size' at all
  • The colored boxes in the map legend are too small, too. There's also some margin between them and their explanation missing. (And some "justify right" for the text showing the height levels in meters.)
  • Its the only window I could find where the "right-click to close window" UI override is ignored. (I would rather have it ignored at the freight overview / train details window, where right-clicking an empty wagon could show what KIND of cargo it can carry. No need to click through the tabs then.)
  • The rectangle corners that show where the virtual camera is at the moment is just guess work. To be fair this needs also fixing at regular Full HD resolution IMHO, as it is pretty indecipherable. There should maybe be some helpful "a little bit darker" 75% transparent overlay on the area where the camera rectangle IS NOT currently - like some kind of vignette effect - I don't know.
  • Because of the rectangle thingie it cannot provide its IMO main function: Showing you the industry that you currently need for a transport line which is nearest to the already existing station. Because even little clicks left and right completely mess with your current in-game postion you have no idea where you are on that minimap window (at least on larger maps).

@Sgt-Nukem
Copy link

@ldpl was looking into this recently citymania-org/cmclient@6f8e0c1

I've not actually tried the above myself.

But I did. I found this "CityMania" thing some weeks ago. Not knowing at all what "CityMania" is supposed to be - the website doesn't tell much - but it said "100% compatible with OpenTTD" so I downloaded it and used it for a multiplayer match with a friend.

a) Yes. The zoom levels for the minimap are far better than in OpenTTD.
b) It crashed after ~ 1 hour of gameplay. So I quickly switched back to the OpenTTD client for multiplayer.

@ldpl
Copy link
Contributor

ldpl commented May 3, 2021

b) It crashed after ~ 1 hour of gameplay. So I quickly switched back to the OpenTTD client for multiplayer.

Have you reported that crash anywhere? Like https://github.com/citymania-org/cmclient/issues for example.
Though if it was on 1.11.0 it's likely already fixed.

@perryprog
Copy link

Any progress on getting a fix for this? The issue is still present on up-to-date versions of macOS for OpenTTD 12.1.

@2TallTyler 2TallTyler added the enhancement Issue would be a good enhancement; we accept Pull Requests! label Oct 19, 2022
@2TallTyler
Copy link
Member

Can someone try this on 13.1? We added interface scaling in 13.0 and I don't have a Mac to test if that resolved this.

@vidmik
Copy link

vidmik commented Apr 21, 2023

Unfortunately it seems like the issue is still there with OpenTTD 13.1 (macOS 13.3.1 Ventura).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue would be a good enhancement; we accept Pull Requests!
Projects
None yet
Development

No branches or pull requests

8 participants