Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #86: Upload on docker failed #87

Merged
merged 1 commit into from May 3, 2021

Conversation

erenes
Copy link
Contributor

@erenes erenes commented Apr 10, 2021

Resolves issue #86 Error when uploading a newgrf to bananas-api running in docker

@TrueBrain
Copy link
Member

TrueBrain commented Apr 10, 2021

Just as a quick FYI, we don't need an issue for a Pull Request. Always feel free to just make the Pull Request, without an issue. Saves you a bit of time / work :)

Of course if you want to, you are free to make an issue first :) Not stopping you :D

@erenes
Copy link
Contributor Author

erenes commented Apr 10, 2021

Haha, tell that to my managers at work ;-)
I'll keep it in mind for future PRs :)

@TrueBrain
Copy link
Member

Haha, tell that to my managers at work ;-)
I'll keep it in mind for future PRs :)

We try to keep things fun instead :P :P :P :D

TrueBrain
TrueBrain previously approved these changes Apr 12, 2021
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One would assume Python handles that for you ...

@TrueBrain
Copy link
Member

This branch is out-of-date with the base branch. Would you mind rebasing? Tnx :)

@erenes
Copy link
Contributor Author

erenes commented Apr 12, 2021

I did that this weekend using the button in github, but then it merges master to my branch instead of rebases properly, and of course, will not use the right commit-message format ;-)

Anyway, done rebased :)

TrueBrain
TrueBrain previously approved these changes May 3, 2021
@TrueBrain TrueBrain merged commit 06bebd8 into OpenTTD:master May 3, 2021
@erenes erenes deleted the fix-docker-upload branch May 3, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants