Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9042: Make multiplayer server list height auto-fill window. #9050

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Fix #9042: Make multiplayer server list height auto-fill window. #9050

merged 1 commit into from
Apr 17, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 17, 2021

Motivation / Problem

#9042 did not fix all combinations of scaling options, and in fact made the normal case slightly worse than before.

Description

This additional change makes the server list automatically fill available height.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@PeterN
Fix OpenTTD#9042: Make multiplayer server list height auto-fill window.
8101df5 
OpenTTD#9042 did not fix all combinations of scaling options. This additional
change makes the server list automatically fill available height.
@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label Apr 17, 2021
@michicc michicc merged commit 3248a6c into OpenTTD:master Apr 17, 2021
@PeterN PeterN deleted the fix-9042 branch April 17, 2021 20:26
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michicc michicc michicc approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeterN @michicc @LordAro