[Gecko Bug 1678044] Fix setting environment variables for wdspec tests #28640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
infra
webdriver
wg-testing_browser
wptrunner
wpt-pr-bot
approved these changes
Apr 22, 2021
The previous patch set the variables too late, after the webdriver server was already started. Pass them down into the server startup code instead Differential Revision: https://phabricator.services.mozilla.com/D97665 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044 gecko-commit: d5f5359358fd630ea92da053211f7ca4c0527c82 gecko-reviewers: maja_zf, marionette-reviewers, whimboo
This ensures that we always pass a profile in the capabilitites. When we're running with a single process it simply unpacks the profile to a temporary folder and passes in that path as a firefox argument. When we're running with multiple processes, that won't work. We could invent a mechanism to get one profile per process, but for simplicity we instead pass in the profile as a base64-encoded string. Depends on D97665 Differential Revision: https://phabricator.services.mozilla.com/D99697 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044 gecko-commit: 0eeb2f14977007e8ac8e0a43c976c490db2661af gecko-reviewers: webdriver-reviewers, whimboo
This requires passing the test_environment into the get_executor_kwargs function so that in the firefox wdspec case we can add a cleanup function to the environment when running wdspec tests. That seems reasonable since we were previously using a variety of data in the environment to setup the kwargs anyway Depends on D99698 Differential Revision: https://phabricator.services.mozilla.com/D101768 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044 gecko-commit: 5281b7443a899dcd538380b4f7c15c46300f9bdd gecko-reviewers: webdriver-reviewers, whimboo
Otherwise it seems to interfere with the rest of the test. Depends on D101768 Differential Revision: https://phabricator.services.mozilla.com/D101769 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044 gecko-commit: 023e75831c48ad93ecfb9252db552158a4aa85e9 gecko-reviewers: webdriver-reviewers, whimboo
moz-wptsync-bot
force-pushed
the
gecko/1678044-1
branch
from
67394c2
to
986ea51
Compare
These appear to assume it's meaningful to set a default binary, but in practice we always pass in one from the command line args. It also fixes breakage from adding an extra argument to the constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous patch set the variables too late, after the webdriver server was already
started. Pass them down into the server startup code instead
Differential Revision: https://phabricator.services.mozilla.com/D97665
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1678044
gecko-commit: 659084e40ec2d3f76ec60fb4015c4b0875974fc6
gecko-reviewers: maja_zf, marionette-reviewers, whimboo