Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation] Simplify <object> fallback handling #28641

Merged
merged 1 commit into from Apr 23, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 22, 2021

If a navigation in an <object> frame will result in a network or HTTP
error, simply inform parent frame to render fallback content instead of
asking the <object> frame to commit a navigation, only for the commit to
be ignored when Blink realizes it should trigger the fallback content
for <object> instead.

Change-Id: I0c5a3889d3aeaad25cdc6190d5bda0a76f5e6a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638444
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875837}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2638444 branch 4 times, most recently from 4555f37 to e97cc7c Compare April 23, 2021 19:12
If a navigation in an <object> frame will result in a network or HTTP
error, simply inform parent frame to render fallback content instead of
asking the <object> frame to commit a navigation, only for the commit to
be ignored when Blink realizes it should trigger the fallback content
for <object> instead.

Change-Id: I0c5a3889d3aeaad25cdc6190d5bda0a76f5e6a9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638444
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#875837}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants