Count uncanceled pointermove as "input" for hadRecentIinput #28646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 22, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2824368
branch
2 times, most recently
from
c2f45f4
to
531b5df
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2824368
branch
2 times, most recently
from
193edec
to
e969851
Compare
We should not count the layout shift while doing touch dragging or resizing widgets. While doing touch dragging, we send out pointermove events, and we do not send pointercancel event. Touch scrolling sends out pointercancel event to cancel all the active touch pointers and does not send any more pointermove events when the scroll starts. Therefore, we add the uncanceled pointermove to the event list that trigger the exclusion window, which sets hadRecentInput to be true, then we do not compute the cumulative layout shift score for touch dragging actions. Bug: 1166952 Change-Id: Ieaaf8a2f5549f078585b706dae34bfbbbd8c501c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824368 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#876440}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2824368
branch
from
e969851
to
18128e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not count the layout shift while doing touch dragging or
resizing widgets. While doing touch dragging, we send out pointermove
events, and we do not send pointercancel event. Touch scrolling sends out
pointercancel event to cancel all the active touch pointers and does not
send any more pointermove events when the scroll starts. Therefore, we
add the uncanceled pointermove to the event list that trigger the
exclusion window, which sets hadRecentInput to be true, then we do not
compute the cumulative layout shift score for touch dragging actions.
Bug: 1166952
Change-Id: Ieaaf8a2f5549f078585b706dae34bfbbbd8c501c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2824368
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#876440}