Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out what to do about extra theme options #5

Open
mithro opened this issue Apr 13, 2021 · 4 comments
Open

Figure out what to do about extra theme options #5

mithro opened this issue Apr 13, 2021 · 4 comments
Assignees
@daniellimws

Comments

@mithro
Copy link

mithro commented Apr 13, 2021

Using the options from the previous theme ends up with the following warnings;

WARNING: unsupported theme option 'header_links' given
WARNING: unsupported theme option 'primary_color' given
WARNING: unsupported theme option 'accent_color' given
WARNING: unsupported theme option 'fixed_drawer' given
WARNING: unsupported theme option 'fixed_header' given
WARNING: unsupported theme option 'header_waterfall' given
WARNING: unsupported theme option 'header_scroll' given
WARNING: unsupported theme option 'show_header_title' given
WARNING: unsupported theme option 'show_drawer_title' given
WARNING: unsupported theme option 'show_footer' given
@mithro
Copy link
Author

mithro commented Apr 14, 2021

So it seems the documentation says color_primary and color_accent should be used but primary_color and accent_color are the values which actually work....

@mithro
Copy link
Author

mithro commented Apr 14, 2021

Actually, it looks like the color_XXX versions are correct but the old color was deep_purple while the new color is deep-purple.

@daniellimws
Copy link

@mithro I don't think we need those options anymore, do we? I believe we just used the default values for them in the previous theme.

Also, since the colors are set by default in the theme, we don't need to worry about them, right?

@mithro
Copy link
Author

mithro commented Apr 15, 2021

@daniellimws - Yeap, I think you are right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniellimws daniellimws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mithro @daniellimws