Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1706223] Fix whitespace handling in clamp() parsing. #28622

Merged
merged 1 commit into from Apr 22, 2021

Conversation

moz-wptsync-bot
Copy link
Collaborator

We should just restore the state when seeing whitespace and an unknown
token like when we do when finding any other token a few lines below.

This is not an issue for most callers (it's only an issue for clamp())
because the other callers use either parse_comma_separated() (for
min/max), or parse_nested_block() (for parens / nested calc()).

Both of those functions restrict the input in such a way that
is_exhausted returns true (a few lines above) and thus we parse
successfully.

Differential Revision: https://phabricator.services.mozilla.com/D112681

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1706223
gecko-commit: 8908151379dc2ae9f5594558ede67711e3617010
gecko-reviewers: xidorn

We should just restore the state when seeing whitespace and an unknown
token like when we do when finding any other token a few lines below.

This is not an issue for most callers (it's only an issue for clamp())
because the other callers use either `parse_comma_separated()` (for
min/max), or `parse_nested_block()` (for parens / nested calc()).

Both of those functions restrict the input in such a way that
is_exhausted returns true (a few lines above) and thus we parse
successfully.

Differential Revision: https://phabricator.services.mozilla.com/D112681

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1706223
gecko-commit: 8908151379dc2ae9f5594558ede67711e3617010
gecko-reviewers: xidorn
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@moz-wptsync-bot moz-wptsync-bot merged commit c332842 into master Apr 22, 2021
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1706223 branch April 22, 2021 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants