Codechange: Add widget text colour and alignment property, along with widget parts. #9063
+268
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
force-pushed
the
widget-set-alignment
branch
from
65a35e6 to
500c8f1
Compare
PeterN
force-pushed
the
widget-set-alignment
branch
2 times, most recently
from
ba043a4 to
cc81ca4
Compare
PeterN
changed the title
LordAro
reviewed
Apr 21, 2021
PeterN
force-pushed
the
widget-set-alignment
branch
3 times, most recently
from
ca8616e to
35099dc
Compare
LordAro
reviewed
Apr 22, 2021
PeterN
force-pushed
the
widget-set-alignment
branch
from
35099dc to
9f33cf2
Compare
PeterN
added a commit
to PeterN/OpenTTD
that referenced
this pull request
May 12, 2021
PeterN
added a commit
that referenced
this pull request
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Currently widget text that is not intended to be aligned to the default behaviour of the widget, or requires a specific text colour, has to be drawn manually by the
DrawWidgets()handler of the window.Description
This PR adds
text_colourandalignproperties to NWidgetCore, with defaults as current behaviour, and NWidgetParts to allow setting these properties from static nested widgets.This allows some window designs to be simplified by removing custom drawing techniques.
Three existing windows are updated by this PR:
Limitations
The existing StringAlignment enum is misnamed for use with images...
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.