[Gecko Bug 1705385] Pass a timeout when signalling firefox in wptrunner #28627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the SIGTERM-then-SIGKILL logic to work as intended. Differential Revision: https://phabricator.services.mozilla.com/D112611 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1705385 gecko-commit: 44a9d348b7199a2ba4ecddc02bcf298746b250c8 gecko-reviewers: ahal
wpt-pr-bot
added
infra
wptrunner
wpt-pr-bot
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the SIGTERM-then-SIGKILL logic to work as intended.
Differential Revision: https://phabricator.services.mozilla.com/D112611
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1705385
gecko-commit: 44a9d348b7199a2ba4ecddc02bcf298746b250c8
gecko-reviewers: ahal