Additional file URL tests #28432
Merged
Additional file URL tests #28432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- file:/C:/ against file://host/ resolves to file://host/C:/ - file://C:/ against file://host/ resolves to file:///C:/
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
|
This caught be by surprise a while ago, my implementation passed all the tests but did behave differently in the last two cases. |
domenic
approved these changes
Apr 12, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests for the handling of drive-letters that are preceded by two slashes.
/C:/againstfile://host/resolves tofile://host/C:/file:/C:/againstfile://host/resolves tofile://host/C:///C:/againstfile://host/resolves tofile:///C:/file://C:/againstfile://host/resolves tofile:///C:/