Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 70bc55cfd6e: snow line height was set while calculating desert line #8989

Merged
merged 1 commit into from Apr 10, 2021
Merged

Fix 70bc55cfd6e: snow line height was set while calculating desert line #8989

merged 1 commit into from Apr 10, 2021

Conversation

TrueBrain
Copy link
Member

Motivation / Problem

Code being wrong. Needs fixing. (zero impact on a user).

Description

Seems I liked copy/pasting just a tiny bit too much.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@TrueBrain
Fix 70bc55c: snow line height was set while calculating desert line
f6b9188 
Seems I liked copy/pasting just a tiny bit too much.
@TrueBrain TrueBrain mentioned this pull request Apr 10, 2021
Merged
@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Apr 10, 2021
@LordAro LordAro merged commit ff6924f into OpenTTD:master Apr 10, 2021
@TrueBrain TrueBrain deleted the copy-paste-is-hard branch April 10, 2021 09:24
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 17, 2021
@TrueBrain @LordAro
Fix 70bc55c: snow line height was set while calculating desert line (O…
fa377fa 
…penTTD#8989)

Seems I liked copy/pasting just a tiny bit too much.
LordAro pushed a commit that referenced this pull request Apr 18, 2021
@TrueBrain @LordAro
Fix 70bc55c: snow line height was set while calculating desert line (#…
4ffe713 
…8989)

Seems I liked copy/pasting just a tiny bit too much.
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterN PeterN PeterN approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TrueBrain @PeterN @LordAro