Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [Win32] Font glyphs of certain widths broke #8990

Merged
merged 1 commit into from
Apr 10, 2021
Merged

Fix: [Win32] Font glyphs of certain widths broke #8990

merged 1 commit into from
Apr 10, 2021
+1 −1

Conversation

nielsmh
Copy link
Contributor

@nielsmh nielsmh commented Apr 10, 2021 •
edited
Loading

Motivation / Problem

Font glyphs between 33 and 39 pixels wide, in the Win32 font system, used wrong alignment and caused glyphs to appear broken.
When in the 33 to 39 pixel range, glyphs without AA were rounded down to 32 pixel pitch, instead of up to 64 pixel pitch.

Example with a 36 pixel wide glyph (the W):
image
This is Georgia, size 18, with 2x font size in Options, AA disabled.

Description

Fix by rounding up instead of down.

Limitations

None expected.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@nielsmh
Fix: [Win32] Font glyphs of certain widths broke
88a78cb 
Font glyphs between 33 and 39 pixels wide, in the Win32 font system, used wrong alignment and caused glyphs to appear broken.
When in the 33 to 39 pixel range, glyphs without AA were rounded down to 32 pixel pitch, instead of up to 64 pixel pitch.
@nielsmh nielsmh added the backport requested This PR should be backport to current release (RC / stable) label Apr 10, 2021
LordAro
LordAro approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix is simple

@nielsmh nielsmh merged commit c800dca into OpenTTD:master Apr 10, 2021
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
@nielsmh nielsmh deleted the win32font-glyphfix branch May 7, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nielsmh @LordAro