Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Adjust scrolling interval of credits to account for text line height #8994

Merged
merged 1 commit into from Apr 10, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 10, 2021

Motivation / Problem

The credits in the "About OpenTTD" window scroll a fixed amount at a fixed interval.

The text is scrolled the same pixel distance, so with larger font sizes can take much longer than intended to scroll through the list.

Description

This patch adjusts the scrolling interval by the text line height, so the time to scroll the list becomes constant. This is done rather than scaling the pixel distance to maintain the appearance of smooth scrolling.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credits probably need updating too :)

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Apr 10, 2021
@michicc michicc merged commit 59b6e46 into OpenTTD:master Apr 10, 2021
@PeterN PeterN deleted the vary-scroll-speed branch April 10, 2021 22:16
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants