-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The current fonts missing some of the characters used in the texts for this language #8988
Comments
Which language are you using? I'd be surprised if it were the English language, as you'd be hard pressed to find a font that doesn't support it! Assuming that's the case, the config file listed above is not the one that's currently being used. The behaviour for reading config & content directories was tweaked slightly in 1.11, see https://github.com/OpenTTD/OpenTTD/blob/master/docs/directory_structure.md for more details about where to look for the active config file. You can also use This is probably the reason why some sound/music sets have disappeared for you as well - they're in directories that are no longer being searched. |
Well I'm using English, that is also what suprise me as prior to 1.11 with the same config there are no issue at all even with 1.11-RC1. I not sure what change for 1.11 release but something must have been gone wrong. |
Would you be able to start the game with a debug window open? Via powershell, navigate to the folder OpenTTD is installed in, and run:
And can you tell us what the black window also opening next to OpenTTD is telling you? Specifically, it should tell the exact character it is missing. That would greatly help us, tnx :) |
Here's screenshot of both windows, text in the terminal shown as:
|
Lookup in the search seem like 0x5C is the backslash character, might have something to do with the system locale as my system locale is Japanese. |
Thank you very much! What is a bit odd to me, that we don't have any string with a |
I tried to reproduce this issue on my own system, so I could debug the problem. But when I use that exact same There are two things weird to me:
I am not sure how to proceed. Hopefully another dev has an idea :) |
I am wrong about that 1.11.0-RC1 had no such issue, cause I redownload that version and found out that it too have this problem. |
Ah, yes, of course! The error was always hiding, but still there. We now only tell that the font is bad, instead of silently falling back to another :D How could I have forgotten about that. So that brings us to the core issue .. the font doesn't know how to render |
Just manage to trace down the change in between 1.10.3 and 1.11.0-beta1. If the debug message is correct then which string is the faulty one? Also the locale maybe to be blame, as stated my system locale is set to Japanese, Shift JIS which is by default will render the character 0x5C as "¥" instead of the regular character "\". In which most English font are unable to render the "¥" character. |
So that might be the core of this issue. If I remember correctly, 1.10 already failed to load the font you selected (but didn't tell you about it). You can see this if you start 1.10.3 with If that is correct, it means that 1.11 tells you about this happening. There is not much we can do about this. We validate fonts to contain all the letters we expect them to, and if they do not, it means it cannot render all our strings. So we find the next best font that can. As it most likely already was falling back to But this relies a bit on my memory that 1.10 already sneaky did this, so that might be good to confirm first :D What a journey this :D Fonts are really really hard ... and why most games just embed a single one and lets you deal with that :) |
Perhaps the debug message could be improved by printing the string where the character is missing? |
Well setting the font to Arial does eliminate the message. |
Okay, in that case, if you don't mind, I am going to close this ticket. As it is not so much a bug, but more that we finally show that something wasn't working before :) Which is a bonus .. too bad it took us a while to remember we added that. Sorry about that :D Happy gaming! |
Thanks for the help anyway. |
Version of OpenTTD
OpenTTD 1.11.0
Issue encountered
When I started up the game, this message is shown:
Here's the [misc] section in the config with my configured fonts:
PS: on a side note after updating my OpenTTD from 1.10.3 to 1.11.0, the OpenMSX and OpenSFX is gone from the list.
For what reason I had no idea but it is no big deal as usual they can download from BaNaNaS.
Also the sound set and music set from the original TTD also gone.
The text was updated successfully, but these errors were encountered: