Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sizing of Multiplayer server list incorrect when GUI zoom doesn't match Font zoom. #9042

Merged
merged 1 commit into from Apr 16, 2021

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Apr 15, 2021

Motivation / Problem

The server information panel is scaled by GUI scale, which can result in a panel that is longer than the server list. This height difference is then maintained when the window is resized to fill the screen.

Description

Instead, specify the minimum size by number of text lines and (summed total) padding.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

…t match Font zoom.

The server information panel was scaled by GUI scale, which could result in a panel that is longer than the server list. This height difference is then maintained when the window is resized to fill the screen.
Instead, specify the minimum size by number of text lines and (summed total) padding.
@PeterN
Copy link
Member Author

PeterN commented Apr 15, 2021

Before this change:
mpbefore

After this change:
mpafter

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Apr 16, 2021
@michicc michicc merged commit 8379940 into OpenTTD:master Apr 16, 2021
@PeterN PeterN deleted the mp-gui-size branch April 16, 2021 18:50
PeterN added a commit to PeterN/OpenTTD that referenced this pull request Apr 17, 2021
OpenTTD#9042 did not fix all combinations of scaling options. This additional
change makes the server list automatically fill available height.
michicc pushed a commit that referenced this pull request Apr 17, 2021
#9042 did not fix all combinations of scaling options. This additional
change makes the server list automatically fill available height.
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 18, 2021
OpenTTD#9042 did not fix all combinations of scaling options. This additional
change makes the server list automatically fill available height.
LordAro pushed a commit that referenced this pull request Apr 18, 2021
#9042 did not fix all combinations of scaling options. This additional
change makes the server list automatically fill available height.
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants