Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/checks/check_license.sh: line 50: git: command not found #18

Closed
mithro opened this issue Apr 16, 2021 · 4 comments · Fixed by #19
Closed

/checks/check_license.sh: line 50: git: command not found #18

mithro opened this issue Apr 16, 2021 · 4 comments · Fixed by #19

Comments

@mithro
Copy link
Contributor

mithro commented Apr 16, 2021

See https://github.com/SymbiFlow/sphinxcontrib-hdl-diagrams/pull/68/checks?check_run_id=2358606670#step:4:36

===========================
Check SPDX identifier
===========================

Checking ./Makefile
Checking ./compat/setup.py
Checking ./compat/sphinxcontrib_verilog_diagrams/__init__.py
Checking ./docs/Makefile
Checking ./docs/code/nmigen/counter.py
Checking ./docs/code/verilog/adder.v
Checking ./docs/code/verilog/carry4-bits.v
Checking ./docs/code/verilog/carry4-whole.v
Checking ./docs/code/verilog/counter.v
Checking ./docs/code/verilog/dff.v
Checking ./docs/code/verilog/lut4.v
Checking ./docs/code/verilog/lutff.v
Checking ./docs/code/verilog/muxcy.v
Checking ./docs/code/verilog/xorcy.v
Checking ./docs/conf.py
Checking ./setup.py
Checking ./sphinxcontrib_hdl_diagrams/__init__.py
Checking ./tests/Makefile
Checking ./tests/code/nmigen/counter.py
Checking ./tests/code/verilog/adder.v
Checking ./tests/code/verilog/fullAdder.v
Checking ./tests/code/verilog/halfAdder.v
Checking ./tests/test.py
/checks/check_license.sh: line 50: git: command not found
@mithro
Copy link
Contributor Author

mithro commented Apr 16, 2021

FYI - @daniellimws

@daniellimws
Copy link

I think you can assign this to me.

@umarcor
Copy link
Contributor

umarcor commented Apr 17, 2021 •
edited
Loading

@daniellimws, adding git to https://github.com/SymbiFlow/actions/blob/main/checks/Dockerfile#L2 should fix it.

RUN apt-get update -qq \
 && DEBIAN_FRONTEND=noninteractive apt-get -y install --no-install-recommends \
    ca-certificates \
    git \
 && apt-get autoclean && apt-get clean && apt-get -y autoremove \
 && update-ca-certificates \
 && rm -rf /var/lib/apt/lists/*

mithro added a commit to mithro/actions that referenced this issue Apr 17, 2021
@mithro
Install git into the Docker image.
a1d04e5 
Should fix f4pga#18.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
@mithro mithro mentioned this issue Apr 17, 2021
Merged
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Adding a third_party module.
1c5d5d2 
 - This should cause the failure seen in f4pga#18.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Install git into the Docker image.
11ded7f 
Should fix f4pga#18.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Adding a third_party module.
a6113e0 
 - This should cause the failure seen in f4pga#18.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Install git into the Docker image.
a61a82f 
Should fix f4pga#18.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
@mithro
Copy link
Contributor Author

mithro commented Apr 18, 2021 •
edited by unfurl-links bot
Loading

Seems the reason why the test did not catch this was that this module didn't have any third_party repositories. See https://github.com/mithro/actions/runs/2372286130?check_suite_focus=true

GitHub
GitHub is where people build software. More than 56 million people use GitHub to discover, fork, and contribute to over 100 million projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install git into the Docker image. mithro/actions
3 participants
@mithro @daniellimws @umarcor