Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ngscopeclient/scopehal-apps
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9eac3bb31bda
Choose a base ref
...
head repository: ngscopeclient/scopehal-apps
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 97ea9dffb1ad
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Apr 24, 2021

  1. Updated submodules

    azonenberg committed Apr 24, 2021
    Copy the full SHA
    b318374 View commit details
  2. Fixed rounding bug causing waveforms to move jerkily in the X axis wh…

    …en the timeline was scrolled
    azonenberg committed Apr 24, 2021
    Copy the full SHA
    bbd85be View commit details
  3. Copy the full SHA
    97ea9df View commit details
Showing with 8 additions and 6 deletions.
  1. +1 −1 doc
  2. +1 −1 lib
  3. +2 −2 src/glscopeclient/WaveformArea_cairo.cpp
  4. +4 −2 src/glscopeclient/WaveformArea_rendering.cpp
2 changes: 1 addition & 1 deletion doc
2 changes: 1 addition & 1 deletion lib
4 changes: 2 additions & 2 deletions src/glscopeclient/WaveformArea_cairo.cpp
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
* *
* glscopeclient *
* *
* Copyright (c) 2012-2020 Andrew D. Zonenberg *
* Copyright (c) 2012-2021 Andrew D. Zonenberg *
* All rights reserved. *
* *
* Redistribution and use in source and binary forms, with or without modification, are permitted provided that the *
@@ -733,7 +733,7 @@ float WaveformArea::GetValueAtTime(int64_t time_fs)
size_t index = BinarySearchForGequal(
(int64_t*)&waveform->m_offsets[0],
waveform->m_offsets.size(),
(int64_t)round(ticks));
(int64_t)ceil(ticks));

//Stop if start of waveform (no lerping possible)
if(index == 0)
6 changes: 4 additions & 2 deletions src/glscopeclient/WaveformArea_rendering.cpp
Original file line number Diff line number Diff line change
@@ -204,12 +204,14 @@ void WaveformArea::PrepareGeometry(WaveformRenderData* wdata, bool update_wavefo
alpha_scaled = min(1.0f, alpha_scaled) * 2;

//Config stuff
wdata->m_mappedConfigBuffer64[0] = -group->m_xAxisOffset / pdat->m_timescale; //innerXoff
int64_t innerxoff = group->m_xAxisOffset / pdat->m_timescale;
int64_t fractional_offset = group->m_xAxisOffset % pdat->m_timescale;
wdata->m_mappedConfigBuffer64[0] = -innerxoff; //innerXoff
wdata->m_mappedConfigBuffer[2] = height; //windowHeight
wdata->m_mappedConfigBuffer[3] = wdata->m_area->m_plotRight; //windowWidth
wdata->m_mappedConfigBuffer[4] = wdata->m_count; //depth
wdata->m_mappedFloatConfigBuffer[5] = alpha_scaled; //alpha
wdata->m_mappedFloatConfigBuffer[6] = pdat->m_triggerPhase * group->m_pixelsPerXUnit; //xoff
wdata->m_mappedFloatConfigBuffer[6] = (pdat->m_triggerPhase - fractional_offset) * group->m_pixelsPerXUnit; //xoff
wdata->m_mappedFloatConfigBuffer[7] = pdat->m_timescale * group->m_pixelsPerXUnit; //xscale
wdata->m_mappedFloatConfigBuffer[8] = ybase; //ybase
wdata->m_mappedFloatConfigBuffer[9] = yscale; //yscale