Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Corrupted savegame could cause heap corruption by writing outside link graph edge matrix. #9046

Merged
merged 1 commit into from Apr 17, 2021

Conversation

Milek7
Copy link
Contributor

@Milek7 Milek7 commented Apr 16, 2021

Motivation / Problem

Corrupted savegame could cause heap corruption by writing outside link graph edge matrix.

Description

Check for valid array index.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')

Copy link
Contributor

@nielsmh nielsmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nielsmh nielsmh added backport requested This PR should be backport to current release (RC / stable) security This issue is possibly a security issue labels Apr 16, 2021
@LordAro LordAro merged commit aade177 into OpenTTD:master Apr 17, 2021
LordAro pushed a commit to LordAro/OpenTTD that referenced this pull request Apr 17, 2021
LordAro pushed a commit that referenced this pull request Apr 18, 2021
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable) security This issue is possibly a security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants