Fix: Corrupted savegame could crash the game by providing invalid gamelog enums. #9045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsmh
reviewed
Apr 16, 2021
nielsmh
added
backport requested
LordAro
approved these changes
Apr 17, 2021
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
Apr 17, 2021
LordAro
pushed a commit
that referenced
this pull request
Apr 18, 2021
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Corrupted savegame could crash the game by providing invalid gamelog enums. (
ctis used as index to saveload description struct array, which potentially could be used to point to SaveLoad description of bigger size and subsequent heap overflow)Description
Check if enums have valid values.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.