Fix: Scale rating minigraphs on station window list. #9075
Merged
+60
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before this change: |
|
Totally forgot but this change also fixes the sizing/spacing of the transport type / cargo filter buttons at the top of the window. |
LordAro
reviewed
Apr 21, 2021
Minigraphs did not adjust size to accomodate large text, either by font size or font zoom, leading to cropped labels. Minigraphs and spacing are now scaled by font zoom, as this seems to behave better than gui zoom in this instance.
PeterN
force-pushed
the
station-rating-window-scale
branch
from
9c87b6a to
df73354
Compare
PeterN
changed the title
LordAro
approved these changes
Apr 22, 2021
LordAro
added
the
backport requested
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 1, 2021
…9075) Minigraphs did not adjust size to accomodate large text, either by font size or font zoom, leading to cropped labels. Minigraphs and spacing are now scaled by font zoom, as this seems to behave better than gui zoom in this instance.
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 1, 2021
…9075) Minigraphs did not adjust size to accomodate large text, either by font size or font zoom, leading to cropped labels. Minigraphs and spacing are now scaled by font zoom, as this seems to behave better than gui zoom in this instance.
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 2, 2021
…9075) Minigraphs did not adjust size to accomodate large text, either by font size or font zoom, leading to cropped labels. Minigraphs and spacing are now scaled by font zoom, as this seems to behave better than gui zoom in this instance.
LordAro
pushed a commit
to LordAro/OpenTTD
that referenced
this pull request
May 2, 2021
…9075) Minigraphs did not adjust size to accomodate large text, either by font size or font zoom, leading to cropped labels. Minigraphs and spacing are now scaled by font zoom, as this seems to behave better than gui zoom in this instance.
LordAro
pushed a commit
that referenced
this pull request
May 3, 2021
Minigraphs did not adjust size to accomodate large text, either by font size or font zoom, leading to cropped labels. Minigraphs and spacing are now scaled by font zoom, as this seems to behave better than gui zoom in this instance.
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Minigraphs did not adjust size to accomodate large text, either by font size or font zoom, leading to cropped labels.
Description
Minigraphs and spacing are now scaled by font zoom, as this seems to behave better than gui zoom in this instance.
Magic scaling values have been simplified and logic is set to explicitly treat cargo waiting <= 30 as a small vertical chart.
Limitations
The pixel-doubling logic to make the rating bar more visible assumes the font size is increased by font zoom level, rather than by setting a larger font size.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.