Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eints allows submitting strings with disallowed UTF8 characters #43

Open
LordAro opened this issue Apr 25, 2021 · 1 comment
Open

eints allows submitting strings with disallowed UTF8 characters #43

LordAro opened this issue Apr 25, 2021 · 1 comment

Comments

@LordAro
Copy link
Member

LordAro commented Apr 25, 2021

Specifically, U+200B (zero-width space)

Results in build failure:

  /home/runner/work/OpenTTD/OpenTTD/src/lang/japanese.txt:2405: FATAL: Unwanted UTF-8 character U+200B in sequence '{BLACK}道路の種類を変更/アップグレードします.Shiftは、コスト見積もりの​​作成/表示を切り替えます'

see OpenTTD/OpenTTD@b721787

& associated block in strgen

https://github.com/OpenTTD/OpenTTD/blob/224625942c44ec33519010ae320b3821d933229a/src/strgen/strgen_base.cpp#L735-L740
@LordAro
Copy link
Member Author

LordAro commented Apr 25, 2021

And OpenTTD/OpenTTD#5589 for why U+200B specifically is disallowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LordAro