Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 1.11.1 release #9049

Merged
merged 65 commits into from Apr 18, 2021
Merged

Prepare for 1.11.1 release #9049

merged 65 commits into from Apr 18, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Apr 17, 2021

Motivation / Problem

We should do a release

Description

Cherry-picked all commits (2 needed manual edits, manually did the Romanian plural-deletion commit) & backported translations.
See final commit for changelog entries

Limitations

Still waiting on #9021 & #9047
Untested.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

glx22 and others added 30 commits April 17, 2021 19:48
…OpenTTD#8945)

This makes the volume control work as most players would expect, affecting
existing playing sounds as well as new sounds.
Debian now provides a default soundfont for FluidSynth via its alternatives system.

In short, FluidSynth is configured to look for `/usr/share/sounds/sf3/default-GM.sf3` as its default soundfont, and each soundfront package (FluidR3, OPL-3, MuseScore...) may provide or override this symlink. By default, FluidSynth is installed on Debian with the `TimGM6mb` soundfont by default due to its limited size.

See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=929185 for further details.
Clamping each sample value to half the available range could cause
unnecessary premature clipping with lots of sounds playing. This change
does not affect the actual volume level.
…penTTD#8959)

Use status >= STATUS_AUTHORIZED as the state criteria for all cases
where updates about other clients are sent.
This avoids the case where a client is informed that another client
has joined but not informed when it later quits, resulting in
stale entries in the client list window.
…n edit box is in focus.

Handle printable input only when the matching WM_CHAR message is incoming.
Without an edit box, do the handling in keydown as usual to support hotkeys.
Font glyphs between 33 and 39 pixels wide, in the Win32 font system, used wrong alignment and caused glyphs to appear broken.
When in the 33 to 39 pixel range, glyphs without AA were rounded down to 32 pixel pitch, instead of up to 64 pixel pitch.
PeterN and others added 5 commits April 17, 2021 19:54
…#9041)

Existing layout included a blank widget above the group list to align with the vehicle list, however since then an additional sort-by row was added.
Group list size tweaks to match normal row size (at least with normal gui and text size.)
Removed reduction of 2 rows in the group list <- main culprit of odd sizing.
Removed fill attribute on buttons which gave strange sizes, and put it on the group info widget instead.
Tweaked various soft-padding values to line up (centreing text with a 1px offset does not make centred text.)
…t match Font zoom.

The server information panel was scaled by GUI scale, which could result in a panel that is longer than the server list. This height difference is then maintained when the window is resized to fill the screen.
Instead, specify the minimum size by number of text lines and (summed total) padding.
@LordAro LordAro force-pushed the release-1111 branch 2 times, most recently from 3fa5ea5 to c4a08b3 Compare April 18, 2021 07:05
OpenTTD#9042 did not fix all combinations of scaling options. This additional
change makes the server list automatically fill available height.
TrueBrain
TrueBrain previously approved these changes Apr 18, 2021
Copy link
Member

@TrueBrain TrueBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you did a smoketest; I did not check anything about this PR other than that the changelog "looks good" :)

@michicc michicc added the preview This PR is receiving preview builds label Apr 18, 2021
@DorpsGek DorpsGek temporarily deployed to preview-pr-9049 April 18, 2021 09:33 Inactive
@michicc
Copy link
Member

michicc commented Apr 18, 2021

Hmm, title game doesn't load on web preview, but loads normally locally for me. Might just be something with the preview, as it works otherwise.

@TrueBrain
Copy link
Member

Hmm, title game doesn't load on web preview, but loads normally locally for me. Might just be something with the preview, as it works otherwise.

if I would be to guess, LZMA is not working in Emscripten. They were going to add the backport, but I don't think they did after all. So that would explain why the titlegame is not loading :D

@stormcone
Copy link
Contributor

Would you consider also backporting #8908? Object and train station filters are new in 1.11.0, and perhaps some users would find the hotkeys useful.

@LordAro
Copy link
Member Author

LordAro commented Apr 18, 2021

Sure, why not

@LordAro LordAro merged commit 0be22ef into OpenTTD:release/1.11 Apr 18, 2021
@LordAro LordAro deleted the release-1111 branch April 18, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview This PR is receiving preview builds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet