Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace shell scripts with proper Python scripts #21

Closed
mithro opened this issue Apr 18, 2021 · 1 comment · Fixed by #20
Closed

Replace shell scripts with proper Python scripts #21

mithro opened this issue Apr 18, 2021 · 1 comment · Fixed by #20
Assignees
@mithro

Comments

@mithro
Copy link
Contributor

mithro commented Apr 18, 2021

The scripts https://github.com/SymbiFlow/actions/blob/main/checks/check_license.sh and https://github.com/SymbiFlow/actions/blob/main/checks/check_python_script.sh are currently written in bash which means they are most certainly broken when handling paths with spaces and other unusual characters.

It would be much better if these scripts were just written in Python instead.
@mithro mithro mentioned this issue Apr 18, 2021
Closed
@mithro mithro self-assigned this Apr 18, 2021
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
08bbfa0 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
f64e922 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
17ccc05 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
e1d2183 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
781feaf 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
8137a58 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
2930fc8 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
b690e02 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
mithro added a commit to mithro/actions that referenced this issue Apr 18, 2021
@mithro
Rewrite the shell scripts in Python.
abb44a7 
Fixes f4pga#21.

Signed-off-by: Tim 'mithro' Ansell <tansell@google.com>
@mithro mithro mentioned this issue Apr 19, 2021
Merged
@mithro
Copy link
Contributor Author

mithro commented Apr 19, 2021

This will be fixed by #20.

@mithro mithro linked a pull request Apr 19, 2021 that will close this issue
Large rework the checks action #20
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mithro mithro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Large rework the checks action mithro/actions
1 participant
@mithro