Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9735: Fix OrderBackup::Reset in non-GUI case #9738

Merged
merged 1 commit into from
Dec 19, 2021

Conversation

JGRennison
Copy link
Contributor

Description

This fixes #9735. The implementation of OrderBackup::Reset was incorrect in the case where from_gui was false.

Limitations

N/A

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@michicc michicc merged commit e08a6e2 into OpenTTD:master Dec 19, 2021
@michicc michicc added the backport requested This PR should be backport to current release (RC / stable) label Jan 1, 2022
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Jan 5, 2022
@JGRennison JGRennison deleted the fix-9735 branch January 9, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiplayer desync due to incorrect OrderBackup handling
3 participants