Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Suppress vehicle age warnings for stopped vehicles #9718

Merged
merged 1 commit into from Dec 20, 2021

Conversation

2TallTyler
Copy link
Member

Motivation / Problem

Per #9700:

When vehicle is manually stopped by player (either due to aesthetic purposes like first locomotive statue, or as timetable holder, or spare cars holder), its age should not bother - it affect only running vehicles.

The same goes for vehicles stopped in depots.

Description

When a vehicle is stopped (red Stopped status bar, not speed == 0, obviously), don't send warnings about its age.

Closes #9700.

For a test savegame, see old_vehicle_test.zip. Road vehicles 1 and 2 will hit the end of their lifespans within a month of loading the savegame. One is running, the other is stopped inside the depot.

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@LordAro LordAro changed the title Fix: Suppress vehicle age warnings for stopped vehicles Change: Suppress vehicle age warnings for stopped vehicles Nov 28, 2021
@rubidium42 rubidium42 merged commit 9c18236 into OpenTTD:master Dec 20, 2021
@2TallTyler 2TallTyler deleted the age_warning branch December 21, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix]: supress vehicle age warnings if vehicle is stopped by player
3 participants