New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some licensing unclarities #48
Conversation
@matthijskooijman: Please review this PR and tell me what I did wrong. Thanks. :D |
0338af6
to
0696a80
Compare
I found the typo on my own, haha. I was being too hasty … |
Other than the typo, I think this PR is perfect :-) |
Think I know why "Unported" wasn't added originally :) Needs shortening... somehow. Also commit message should be in the usual style - |
Maybe use the customary shortenings for the licenses? CC-BY-SA-3.0 Unported? Or maybe remove unported everywhere, since that seems to be sortof implied? |
0696a80
to
0d24583
Compare
0d24583
to
82531ee
Compare
I shortened the offending line, I hope this is OK. Please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is happy, so it must be fine, right?
This PR fixes some of the complaints from #46.
Changes:
opensfx.sfo
(should beopensfx.psfo
)opensfx.psfo
(I checked this, it really is Unported)