Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codechange: do not use all upper case enumerators in a scoped enum #9733

Merged
merged 1 commit into from Dec 5, 2021
Merged

Codechange: do not use all upper case enumerators in a scoped enum #9733

merged 1 commit into from Dec 5, 2021

Conversation

rubidium42
Copy link
Contributor

@rubidium42 rubidium42 commented Dec 5, 2021 •
edited

Motivation / Problem

Inconsistency in the way of writing of enumerators for scoped enums.

Description

Consensus in #9725 seemed to be that for scoped enums we should not use all uppercase but rather CamelCase.

Limitations

Deviates from the coding style in https://wiki.openttd.org/en/Development/Coding%20style. But that's where OpenTTD/wiki-data#15 is for.

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@rubidium42 rubidium42 mentioned this pull request Dec 5, 2021
Closed
@michicc michicc merged commit ad89601 into OpenTTD:master Dec 5, 2021
@rubidium42 rubidium42 deleted the NoUppercaseEnum branch December 5, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michicc michicc michicc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rubidium42 @michicc