Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Error]: The setting name "Screen resolution" is misleading #9734

Open
LC-Zorg opened this issue Dec 5, 2021 · 9 comments
Open

[Error]: The setting name "Screen resolution" is misleading #9734

LC-Zorg opened this issue Dec 5, 2021 · 9 comments
Labels
component: interface This is an interface issue

Comments

@LC-Zorg
Copy link

LC-Zorg commented Dec 5, 2021

Version of OpenTTD

12.1 and earlier, possibly from 0.6.0-beta1 (r10704)

Expected result

This setting changes the window size, not the screen resolution, so it should be called "Screen / Window size" or "Gameplay screen / window size".

Actual result

The title of the option "Screen resolution" suggests that it changes the screen resolution, which is not true. This is confusing and misleading as to the actual function of the setting. Report #9717 is one confirmation of this issue. I also thought that was the way it worked.

Steps to reproduce

n/a

@LC-Zorg
Copy link
Author

LC-Zorg commented Dec 5, 2021

Question: is this feature needed at all? The only use I see for it is to take screenshots of a certain resolution, but that's a bit of a weak motivation. I don't see any other reason. If someone wants to play on a smaller window, they can minimize it and choose any size.
In my opinion, if it were to be, it clearly requires a name change. On the other hand, if the goal would be to add an actual resolution setting function in the near future in place of the one that resizes the window, it might be better to keep the wrong name for the time being. Here I would like to point out once again that adding this function would only make sense if it were a multiplier of x2, x3, x4, ... Choosing any resolution other than multiple would blur the game view, so making the function work as is currently visible would be a bad solution.

@glx22
Copy link
Contributor

glx22 commented Dec 5, 2021

If you enable "full screen" it will actually change the screen resolution (at least on Windows).

@Eddi-z
Copy link
Contributor

Eddi-z commented Dec 5, 2021

we could instead disable the setting if anything other than "full screen" is used

@LC-Zorg
Copy link
Author

LC-Zorg commented Dec 5, 2021

If you enable "full screen" it will actually change the screen resolution (at least on Windows).

I never used full screen mode and didn't think it actually worked. Man learns all his life :D

we could instead disable the setting if anything other than "full screen" is used

I think that would be appropriate. But the question is, could this resolution change work also for a windowed game? Then choosing the resolution 1/2, 1/3, 1/4 should give a very good effect without blurring for screens with high resolutions.

@Eddi-z
Copy link
Contributor

Eddi-z commented Dec 6, 2021

I think that would be appropriate. But the question is, could this resolution change work also for a windowed game? Then choosing the resolution 1/2, 1/3, 1/4 should give a very good effect without blurring for screens with high resolutions.

there's a gui zoom setting for that

@TrueBrain TrueBrain changed the title [Error]: The setting name "Screen resolution" is incorrect and misleading [Error]: The setting name "Screen resolution" is misleading Mar 10, 2022
@TrueBrain
Copy link
Member

we could instead disable the setting if anything other than "full screen" is used

I like that solution.

@TrueBrain TrueBrain added good first issue Good for newcomers enhancement Issue would be a good enhancement; we accept Pull Requests! labels Mar 10, 2022
@orudge
Copy link
Contributor

orudge commented Mar 11, 2022

Or it could be renamed to "Window size" if it's not full screen? I at least still like to pick a resolution even though I use OpenTTD in a window, rather than dragging the window to an arbitrary size.

@PeterN
Copy link
Member

PeterN commented Mar 11, 2022

This is absolutely standard terminology...

image
image

@TrueBrain
Copy link
Member

Or it could be renamed to "Window size" if it's not full screen? I at least still like to pick a resolution even though I use OpenTTD in a window, rather than dragging the window to an arbitrary size.

Fair enough, that is enough to leave it in. What to name it really becomes bikeshedding .. what-ever you do, someone will complaint. So I suggest to just leave it as it is ..

@TrueBrain TrueBrain removed good first issue Good for newcomers enhancement Issue would be a good enhancement; we accept Pull Requests! labels Mar 11, 2022
@LordAro LordAro added the component: interface This is an interface issue label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue
Projects
None yet
Development

No branches or pull requests

7 participants