Feature: Added hotkeys to tooltips and dropdown menu's #9732
Conversation
Kuhnovic
force-pushed
the
hotkeys_in_tooltip
branch
from
49aaab1
to
ae4e146
Compare
Kuhnovic
force-pushed
the
hotkeys_in_tooltip
branch
from
ae4e146
to
3984257
Compare
| {"SHIFT", WKC_SHIFT, "Shift"}, | ||
| {"CTRL", WKC_CTRL, "Ctrl"}, | ||
| {"ALT", WKC_ALT, "Alt"}, |
There was a problem hiding this comment.
These need to be translatable strings. For example, in Germany the Ctrl key is called Strg. Also keep in mind that many hotkeys on Mac systems use the Cmd key where other platforms use Ctrl.
There was a problem hiding this comment.
As pointed out by dP in the development discord channel, I need to do quite a bit more work on the translating / formatting parts. I will take your comments into account as well.
| if (keycode & WKC_SHIFT) append("Shift"); | ||
| if (keycode & WKC_CTRL) append("Ctrl"); | ||
| if (keycode & WKC_ALT) append("Alt"); | ||
| if (keycode & WKC_META) append("Meta"); |
| const bool is_global = keycode & WKC_GLOBAL_HOTKEY; | ||
| ss << (is_global ? "[" : "("); | ||
| ss << KeycodeToDisplayString(keycode); | ||
| ss << (is_global ? "]" : ")"); |
There was a problem hiding this comment.
Make sure this results in meaningful results on right-to-left languages (mainly Arabic and Hebrew.)
|
What would be most useful in theme of shortcuts is an option to select these shortcuts in the game interface. Then the average player wouldn't only find out what shortcuts exist, but could also change them. :) First of all (sorry, maybe it's obvious, but I'm almost blind when it comes to reading the code) are these shortcut tooltips permanent or depending on the chosen setting in the config file? Personally, I use completely revised shortcuts, and it would be weird to see hints that are unrelated to the facts. The second note concerns the tooltips in the dropdown menu - I believe that they are redundant and reduce readability unnecessarily. Minimal, but they do decrease. Moreover, once someone knows about this shortcuts, this information becomes intrusive after time. In both visible cases (L / Shift + F11) these tooltips will be available after hovering over the icon. I think that is really enough. :)
|
|
@LC-Zorg A hotkey configuration window would indeed be great, but that would be a PR on its own ;) The hotkeys are read from hotkeys.cfg, so they will display whatever you set them to. The dropdown items can indeed be quite intrusive, especially if there are multiple key combination configured. I added them for completeness, but I'm not entirely sure if I want to keep them. For now I'll keep them in, I can always throw those part of the code away later.
|
|
I'm giving up on this one, it's becoming a huge hassle for something that I initially thought would be relatively simple to do. I don't want to spend so much time that's going to a relatively small contribution to the overall gameplay. |
Motivation / Problem
OpenTTD is full of useful hotkeys, but these are never shown to the user. Having these hotkeys visible makes it much easier to learn about them.
Description
Tooltips
Dropdown menu's
The hotkeys have been added to:
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.