Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new-style DiscreteTrajectory in Entwurf #3225

Merged
merged 31 commits into from
Dec 7, 2021
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Dec 4, 2021

  1. Pass the downsampling parameters at construction and not when creating the history: they are used each time we add a new segment. (Not serialized yet.)
  2. Only serialize the tail of the trajectory (12'000 ending at the end of the backstory).
  3. Use segments instead of forks everywhere.
  4. Simplify the checkpointing code now that we can easily denote the backstory.
  5. Simplify/complete the reanimation code using Merge. (Not tested yet.)
  6. Fix the tests to use the new trajectory factories, and add a test for tail serialization.

#2400.

@eggrobin eggrobin added the LGTM label Dec 5, 2021
@pleroy
Copy link
Member Author

pleroy commented Dec 5, 2021

retest this please

Sorry, something went wrong.

1 similar comment
@pleroy
Copy link
Member Author

pleroy commented Dec 5, 2021

retest this please

@pleroy pleroy merged commit 683cda8 into mockingbirdnest:Entwurf Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants