New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
symbiflow_route needs to fail when timing is not met #2331
Comments
I believe that, rather than having this check in the wrapper, this should be within VPR, and the option passed to it to hard fail in case of timing violations produced during the analysis step. |
As I have said multiple times, timing failure must cause the tooling to exit with an error by default. There can be an option to allow it to continue with a timing fail. |
My suggestion was to keep this check within VPR, rather than in the wrapper. Not sure if VTR devs will want to fail by default in case of timing violations during the analysis step, but in case we might just add the option in the wrapper. Either way this should end up in VPR |
I'm closing this because the wrappers were removed from this repo, and the issue is tracked in verilog-to-routing/vtr-verilog-to-routing#1928. |
Followup: verilog-to-routing/vtr-verilog-to-routing#2060 has been merged, so we can now pick up work on correct handling in the F4PGA flow. |
The
symbiflow_route
wrapper needs to determine if VPR met the desired timing, and exit with an error status if it does not. Perhaps we can add an option for skipping the timing check, but the default should be that timing is checked, and the flow fails if timing is not met.See enjoy-digital/litex#1110.
The text was updated successfully, but these errors were encountered: