Fix #9546: Crash when no industries are present in game #9726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Resolves #9546:
When industries are removed entirely using the feature disabler NewGRF, a crash occurs when the player opens up the "Fund New Industries" window.
Description
In the
GetIndustrySpec
function withinindustry_cmp.cpp
, changed the assertion statement fromassert(thistype < NUM_INDUSTRYTYPES);
toassert(thistype <= NUM_INDUSTRYTYPES);
This resolves #9546 - now instead of the Fund New Industries window crashing the game, it shows up empty.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.