Codechange: do not use all upper case enumerators in a scoped enum #9733
+28
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Inconsistency in the way of writing of enumerators for scoped enums.
Description
Consensus in #9725 seemed to be that for scoped enums we should not use all uppercase but rather CamelCase.
Limitations
Deviates from the coding style in https://wiki.openttd.org/en/Development/Coding%20style. But that's where OpenTTD/wiki-data#15 is for.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.