Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottom: fix build on aarch64 #107237

Merged
1 commit merged into from Dec 20, 2020
Merged

bottom: fix build on aarch64 #107237

1 commit merged into from Dec 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2020

Motivation for this change

I want to use bottom on my raspberry pi, but it didn't build.

Things done

Remove a cargo config included in the bottom repository, because it sets the aarch64 compiler to something that doesn't exist in our environment. I didn't see anything useful in this file, since it would all be handled by the nixpkgs Rust infrastructure for different platforms and cross-compilation cases.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Dec 20, 2020

CC @berbiche

@berbiche
Copy link
Member

@petabyteboy this looks fine to me. I don't have the hardware to test this though

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant