Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i3lock-color: reenable all platforms #107228

Merged
merged 1 commit into from Dec 19, 2020

Conversation

clkamp
Copy link
Contributor

@clkamp clkamp commented Dec 19, 2020

It was restricted in 40b347f due to its
need for the SSE2 instruction set. However the upstream issue is now
resolved [1], so reenable support for all platforms.

Tested on RaspberryPi 4B

[1] Raymo111/i3lock-color#44

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

It was restricted in 40b347f due to its
need for the SSE2 instruction set. However the upstream issue is now
resolved [1], so reenable support for all platforms.

[1] Raymo111/i3lock-color#44
@clkamp clkamp requested a review from malyn December 19, 2020 22:15
@prusnak prusnak merged commit a14a58a into NixOS:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants