Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify CAN CRC (#333) #388

Merged
merged 3 commits into from Dec 19, 2020
Merged

Verify CAN CRC (#333) #388

merged 3 commits into from Dec 19, 2020

Conversation

pd0wm
Copy link
Contributor

@pd0wm pd0wm commented Dec 19, 2020

This should verify the checksum and resolve #333. Anything else you'd like to add? Are there tests I need to update?

@pd0wm pd0wm marked this pull request as ready for review December 19, 2020 21:55
@azonenberg azonenberg merged commit 86f127f into ngscopeclient:master Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAN decode: Check packet CRCs
2 participants