Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxi-tools: init at 1.21 #107227

Merged
merged 3 commits into from Jan 17, 2021
Merged

lxi-tools: init at 1.21 #107227

merged 3 commits into from Jan 17, 2021

Conversation

vq
Copy link
Contributor

@vq vq commented Dec 19, 2020

Motivation for this change

Add https://lxi-tools.github.io/

My first package. Added myself as maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • Debian
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

IvarWithoutBones
IvarWithoutBones requested changes Dec 21, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor nits, otherwsie LGTM 👍

pkgs/development/libraries/liblxi/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/liblxi/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/liblxi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/lxi-tools/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/lxi-tools/default.nix Outdated Show resolved Hide resolved
@vq vq force-pushed the add/lxi-tools branch 2 times, most recently from 362d1d2 to dacc621 Compare December 21, 2020 17:35
IvarWithoutBones
IvarWithoutBones approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 107227 run on x86_64-linux 1

2 packages built:
  • liblxi
  • lxi-tools

@vq
Copy link
Contributor Author

vq commented Dec 21, 2020

Suggestions added. Disregard the extra force-push, git-rebase-squash ate my co-authored-by lines.

@SuperSandro2000 SuperSandro2000 changed the title Add/lxi tools lxi-tools: init at 1.21 Jan 2, 2021
SuperSandro2000
SuperSandro2000 requested changes Jan 2, 2021
View reviewed changes
pkgs/development/libraries/liblxi/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/liblxi/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/liblxi/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/lxi-tools/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/lxi-tools/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107227 run on x86_64-linux 1

2 packages built:
  • liblxi
  • lxi-tools

vq and others added 3 commits January 17, 2021 12:23
@vq
maintainers: add vq
03a317d
@vq @IvarWithoutBones @SuperSandro2000
liblxi: init at 1.13
5c56cfd 
Apply suggestions from code review

Co-authored-by: Ivar <41924494+IvarWithoutBones@users.noreply.github.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@vq @IvarWithoutBones @SuperSandro2000
lxi-tools: init at 1.21
143091f 
Apply suggestions from code review

Co-authored-by: Ivar <41924494+IvarWithoutBones@users.noreply.github.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107227 run on x86_64-linux 1

2 packages built:
  • liblxi
  • lxi-tools

@SuperSandro2000 SuperSandro2000 merged commit 9ecaa3c into NixOS:master Jan 17, 2021
@vq vq deleted the add/lxi-tools branch January 18, 2021 16:04
ajs124
ajs124 reviewed Jun 23, 2022
View reviewed changes
maintainers/maintainer-list.nix
@@ -9660,6 +9660,10 @@
email = "oliver.huntuk@gmail.com";
name = "Oliver Hunt";
};
vq = {
email = "vq@erq.se";
name = "Daniel Nilsson";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't actually a correct entry to maintainers-list, because it misses the github handle and id, but 🆗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 left review comments

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vq @SuperSandro2000 @ajs124 @IvarWithoutBones