Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bottom: 0.5.4 -> 0.5.6 #107234

Merged
1 commit merged into from Dec 20, 2020
Merged

bottom: 0.5.4 -> 0.5.6 #107234

1 commit merged into from Dec 20, 2020

Conversation

berbiche
Copy link
Member

Motivation for this change

Update https://github.com/ClementTsang/bottom

Changes since 0.5.4:

  • Fixed temperature sensors not working on non-Linux platforms.
  • Fixed CPU graph colours not matching the legend in the "all" state.

Update done automatically with nix run 'nixpkgs#nix-update' -- --version 0.5.6 bottom

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link

ghost commented Dec 20, 2020

Tested on NixOS x86_64-linux and NixOS aarch64-linux. It didn't work on aarch64-linux, but that's unrelated and I'll open another PR to fix it.

@ghost ghost merged commit 71ca741 into NixOS:master Dec 20, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@berbiche