Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-c: 0.6.18 -> 0.7.0 #107751

Closed
wants to merge 1 commit into from
Closed

Conversation

freezeboy
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000

This comment has been minimized.

@freezeboy freezeboy marked this pull request as draft December 28, 2020 09:17
@freezeboy
Copy link
Contributor Author

Setting as a draft ... many fixes are required to merge that

@freezeboy
Copy link
Contributor Author

Very strange, I guess another package has been updated as I can build:

  • manim
  • hydron (will submit an update)

without trouble

@primeos
Copy link
Member

primeos commented Dec 28, 2020

Looking at the build output from @SuperSandro2000 (I took the liberty to hide the comment because the output was pretty long, hope no one minds) this seems to be another instance of nondeterminism in rav1e that causes some tests to fail (I've already seen a similar failure once before but the chances are luckily low - I'll try to have a look if upstream is already aware of this).

I'll try to build rav1e and ffmpeg-full with this, if it works it should be good to go.

@freezeboy any particular reason for this PR (I'm just a bit surprised)? Do you depend on cargo-c and would you be interested in maintaining it?

@freezeboy
Copy link
Contributor Author

@primeos Not really needed it, just trying to get as much updated packages as possible.

I can also maintain it, if it helps

@primeos
Copy link
Member

primeos commented Dec 28, 2020

I just checked my release feed and didn't see a new entry. Turns out I already applied this update to staging: 4454fec

@primeos Not really needed it, just trying to get as much updated packages as possible.
I can also maintain it, if it helps

Ok, in that case it's probably better to focus on other packages (I'm subscribed to release updates and this package is only required for rav1e anyway). But thanks for the offer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants