Result of nixpkgs-review pr 107781 run on x86_64-linux 1

fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.

fdl12 is a deprecated license, check if project uses fdl12Plus or fdl12Only and change meta.license accordingly.

The licenses are handled centrally for all plasma stuff, so while your comment is absolutely valid, it's separate for the purpose of this.

This fixes kinfocenter for me:

• patch CMakeLists.txt for kinfocenter: hamburger1984@11a77e8
• don't specify outputs for systemsettings (this moves the executable into the bin folder of systemsettings output): hamburger1984@fb65f8c

@ttuegel @jtojnar could you take a look?

@SuperSandro2000 whether you want to solve it by overriding the broken symlink with a correct one or patching the build script is just a matter of maintainer’s preference. I like to do the latter since patch failure will let me know when something changed but replacing a symlink is an easy fix to do and some maintainers might prefer that.

I suspect you @hamburger1984 is disabling the multiple outputs because they cannot find the binary output in out. But that is fine, we have bin output so it gets installed there. Just the patching of CMakeScripts.txt should be sufficient if you change the interpolation to ${lib.getBin systemsettings}, ${systemsettings.bin} or (using the fact that bin is first and thus the default output) just ${systemsettings}.

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107781 run on x86_64-linux 1

Duplicate of #108356 (or vice-versa), where I addressed this issue using ln -sf ${lib.getBin systemsettings}/bin/systemsettings5 $out/bin/kinfocenter in preFixup in 64e191c

Yours has better documentation @eliasp so let's use that instead. It's straight forward, self-contained and documented.