Staging next (with gcc 10, binutils 2.34 and autoconf 2.70) #107783
Merged
+1,812
−2,852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
gobject-introspection doesn't currently cross-compile (see #88222), but polkit is somewhat essential for many system components. By disabling gobject-introspection when cross-compiling, we get it to build.
libjack2 doesn't cross-compile, see #96548. The pulseaudio NixOS module uses pkgs.alsaPlugins to create its asound.conf, so let's make sure that one can be built when cross-compiling.
…ompiling When cross-compiling, pulseaudio seems to not find some m4 macro providing GSETTINGS_RULES. However, apart from the obviously missing gsettings support, this works just fine.
pulseaudio: fix cross-compilation
Needs pin to older autoconf 2.69
Several aarch64 builds fail with is referenced by DSO followed by bin/ld: final link failed: bad value. This seems related to libgcc_s.so. #108111
Fix NixOS cross-compilation SD Image
|
@FRidh I don't think this line is right. It changes the top-level
autoconf attribute to buildPackages.autoconf270 -- not an override to a
particular package.
https://github.com/NixOS/nixpkgs/commit/136c0d01d25b030c0d103e989de2d5340904dc51#https://github.com/NixOS/nixpkgs/commit/136c0d01d25b030c0d103e989de2d5340904dc51#diff-ab5748dc9567516fefba8344056b51ec1866adeace380f46e58a7af3d619ea22L8575
|
|
@alyssais can you inline-quote? The link doesn't seem to work for me. |
|
I can't see a problem in that commit, but perhaps if you're more specific... |
|
This line 136c0d0#diff-ab5748dc9567516fefba8344056b51ec1866adeace380f46e58a7af3d619ea22R11122 |
This was accidentally added in 136c0d0 when doing a search & replace.
|
getting this now when tyring to do a nixpkgs-review: seeing as |
|
Oh yeah sorry for the pasting error with the link. |
Forgot about that one when merging. Tracking in #108304 |
ghost
mentioned this pull request
This was referenced Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
Includes #89793.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)